Skip to content

Setting pythonpath for all environments #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2023
Merged

Setting pythonpath for all environments #1180

merged 3 commits into from
Mar 3, 2023

Conversation

gavin-aguiar
Copy link
Contributor

Description

Setting pythonpath to add customer dependencies for all environments.
This change would resolve issues with custom containers using custom libraries.

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Feb 17, 2023 •
edited
Loading

Codecov Report

Merging #1180 (8f68a10) into dev (840a894) will decrease coverage by 53.00%.
The diff coverage is n/a.

❗ Current head 8f68a10 differs from pull request most recent head 2fad546. Consider uploading reports for the commit 2fad546 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1180       +/-   ##
===========================================
- Coverage   84.91%   31.92%   -53.00%     
===========================================
  Files          34       34               
  Lines        1889     1889               
  Branches      363      363               
===========================================
- Hits         1604      603     -1001     
- Misses        220     1285     +1065     
+ Partials       65        1       -64
Flag Coverage Δ
unittests 31.92% <ø> (-52.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 25.00% <0.00%> (-71.28%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-69.61%) ⬇️
azure_functions_worker/dispatcher.py 19.74% <0.00%> (-69.24%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...ared_memory_data_transfer/shared_memory_manager.py 26.80% <0.00%> (-55.68%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/bindings/datumdef.py 20.13% <0.00%> (-54.17%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pdthummar pdthummar merged commit a858fbf into dev Mar 3, 2023
@pdthummar pdthummar deleted the gaaguiar/update_pythonpath branch March 3, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunchuWang YunchuWang YunchuWang approved these changes

@pdthummar pdthummar pdthummar approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavin-aguiar @YunchuWang @pdthummar